Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added channel complition logs #1204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added channel complition logs #1204

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057a501
Added channel complition logs
Nov 6, 2024
f05114b
Make channel closed logs more human readable
Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,9 +337,13 @@ func main() {

// TODO - cleaner shutdown across these channels
<-ctx.Done()
log.FromContext(ctx).Infof("Completed <-ctx.Done()")
Copy link
Member

@denis-tingaikin denis-tingaikin Nov 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. please do not use formating.
  2. use more human readable logs
Suggested change
log.FromContext(ctx).Infof("Completed <-ctx.Done()")
log.FromContext(ctx).Info("Application context is done :received OS signal")

<-srvErrCh
log.FromContext(ctx).Infof("Completed <-srvErrCh")
<-vppErrCh
log.FromContext(ctx).Infof("Completed <-vppErrCh")
<-cleanupDoneCh
log.FromContext(ctx).Infof("Completed <-cleanupDoneCh")
}

func setupDeviceMap(ctx context.Context, cfg *config.Config) map[string]string {
Expand Down
Loading