-
Notifications
You must be signed in to change notification settings - Fork 0
๐ Board > Rest Client: ์ํฌํธ, Non-static ์ ํ ๋ฑ Nettee Client์ ์์ ์ด ๋ ๋ฐ์๋ ์์ญ์ ์์ #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
silberbullet
wants to merge
7
commits into
main
Choose a base branch
from
feature/fix-board-rest-client
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5a8b9bf
build(board): add board target rest client module
silberbullet 55d601a
build(board): add board api in board rest client adapter module
silberbullet a1fde39
feat(board): add nettee client bean to board domain http connect
silberbullet 7df9a5b
fix(board): fix board command nettee client port
silberbullet 993a454
build(gradle): add boar rest client property
silberbullet 09a908f
build(monolith): add rest client core module
silberbullet ac69a1a
refactor(rest-client): add strip method and add baseUrl init value
silberbullet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...rd/port/BoardCommandNetteeClientPort.java โ ...on/port/BoardCommandNetteeClientPort.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
package nettee.board.port; | ||
package nettee.board.application.port; | ||
|
||
import nettee.board.domain.Board; | ||
|
||
public interface BoardCommandNetteeClientPort { | ||
Board save(); | ||
Board save(Board board); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,8 @@ | ||
val boardApi: String by project | ||
val boardApplication: String by project | ||
|
||
dependencies { | ||
api(project(":board:board-application")) | ||
api(project(boardApi)) | ||
api(project(boardApplication)) | ||
api(project(":rest-client")) | ||
} |
24 changes: 0 additions & 24 deletions
24
...riven/board-nettee-client/src/main/java/nettee/board/client/BoardCommandNetteeClient.java
This file was deleted.
Oops, something went wrong.
26 changes: 26 additions & 0 deletions
26
...oard-nettee-client/src/main/java/nettee/board/client/BoardCommandNetteeClientAdapter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
package nettee.board.client; | ||
|
||
import lombok.RequiredArgsConstructor; | ||
import nettee.board.domain.Board; | ||
import nettee.board.application.port.BoardCommandNetteeClientPort; | ||
import nettee.restclient.NetteeClient; | ||
import nettee.client.request.NetteeRequest; | ||
import org.springframework.stereotype.Component; | ||
|
||
@Component | ||
@RequiredArgsConstructor | ||
public class BoardCommandNetteeClientAdapter implements BoardCommandNetteeClientPort { | ||
|
||
private final NetteeClient netteeClient; | ||
|
||
@Override | ||
public Board save(Board board) { | ||
return netteeClient.post(NetteeRequest.<Board>builder() | ||
.domain("board") | ||
.path("/boards") | ||
.body(board) | ||
.responseType(Board.class) | ||
.build() | ||
); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ด ์ฝ๋๋ Board ๋ชจ๋์ธ๋ฐ, public Board save(Board board) ํจ์๋ฅผ ์ ์ํ์ต๋๋ค.
ํธ์ถํ๋ ค๋ api์ ๊ฐ์ ๋ชจ๋(=board)์ ๋๋ค.
๊ฐ๋จํ๊ฒ ์ฌ์ฉ ์์๋ฅผ ์ค๋ช ํด์ฃผ์ ๊ฑฐ๋ผ๊ณ ๋ด๋ ๋ ๊น์?