NETOBSERV-1981: Fix Exporters form view

[Amoghrd]

Description

Fix form view for exporters section

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci-robot]

@Amoghrd: This pull request references NETOBSERV-1981 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Description

Fix form view for exporters section

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
• If so, make sure the JIRA epic is labeled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
• If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
• If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
• Standard QE validation, with pre-merge tests unless stated otherwise.
• Regression tests only (e.g. refactoring with no user-facing change).
• No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jpinsonneau]

Code looks good, did you give a try ?

[Amoghrd]

nope not yet. Will try it now

[Amoghrd]

Do the changes to files other than the CSV look good?

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:52cc70c
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-52cc70c
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-52cc70c

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:52cc70c make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-52cc70c

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-52cc70c
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:cf05dd6
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-cf05dd6
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cf05dd6

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:cf05dd6 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-cf05dd6

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cf05dd6
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[Amoghrd]

OpenTelemtry does not show up as default now but I dont see the sub fields for any of the exporters so there is still something missing

[Amoghrd]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.87%. Comparing base (f99da52) to head (3466606).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   63.96%   63.87%   -0.10%     
==========================================
  Files          76       76              
  Lines       11030    11030              
==========================================
- Hits         7055     7045      -10     
- Misses       3534     3542       +8     
- Partials      441      443       +2     

Flag	Coverage Δ
unittests	63.87% <ø> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

[jotak]

@Amoghrd after changing the base CSV you need to run make update-bundle

[Amoghrd]

I am getting error when I run make update-bundle

Error: not all generators ran successfully
run controller-gen rbac:roleName=manager-role crd:crdVersions=v1 paths=./... output:crd:artifacts:config=config/crd/bases output:webhook:dir=./config/webhook webhook -w to see all available markers, or controller-gen rbac:roleName=manager-role crd:crdVersions=v1 paths=./... output:crd:artifacts:config=config/crd/bases output:webhook:dir=./config/webhook webhook -h for usage
make: *** [manifests] Error 1

But these files get updated

modified: apis/flowcollector/v1beta1/zz_generated.deepcopy.go
modified: apis/flowcollector/v1beta2/zz_generated.deepcopy.go
modified: apis/flowmetrics/v1alpha1/zz_generated.deepcopy.go
modified: config/crd/bases/flows.netobserv.io_flowcollectors.yaml
modified: config/crd/bases/flows.netobserv.io_flowmetrics.yaml
modified: config/rbac/role.yaml

[jotak]

@Amoghrd you must have a too old (or too recent?) version of the tools used to generate the bundle. Can you delete bin/controller-gen and bin/operator-sdk then retry?

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:cd8c844
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-cd8c844
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cd8c844

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:cd8c844 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-cd8c844

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-cd8c844
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[Amoghrd]

@jotak Deleted the bin/controller-gen and bin/operator-sdk and could see the bundle/manifests/netobserv-operator.clusterserviceversion.yaml change still. But did not get any errors when I ran make update-bundle.
But the above error screenshot wrt the other exporters section still seen even when not selected is not rectified. So dont know how to go about this

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:8ba7fc6
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-8ba7fc6
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8ba7fc6

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:8ba7fc6 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-8ba7fc6

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-8ba7fc6
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[Amoghrd]

Tried the first fix with make update-bundle still same issue as above

[Amoghrd]

/ok-to-test

[github-actions]

New images:

• quay.io/netobserv/network-observability-operator:93dda85
• quay.io/netobserv/network-observability-operator-bundle:v0.0.0-93dda85
• quay.io/netobserv/network-observability-operator-catalog:v0.0.0-93dda85

They will expire after two weeks.

To deploy this build:

# Direct deployment, from operator repo
IMAGE=quay.io/netobserv/network-observability-operator:93dda85 make deploy

# Or using operator-sdk
operator-sdk run bundle quay.io/netobserv/network-observability-operator-bundle:v0.0.0-93dda85

Or as a Catalog Source:

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: netobserv-dev
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-93dda85
  displayName: NetObserv development catalog
  publisher: Me
  updateStrategy:
    registryPoll:
      interval: 1m

[Amoghrd]

@jotak The exporters view is still not fixed with latest changes and still facing the issue mentioned here