NETOBSERV-1977 automatically disable filters when not available in prometheus #662

jpinsonneau · 2024-12-04T15:42:12Z

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

openshift-ci · 2024-12-04T15:42:17Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

web/src/components/netflow-traffic.tsx

jpinsonneau · 2024-12-05T15:33:07Z

web/src/components/netflow-traffic.tsx

+                // update filters to retrigger query without showing the error
+                updateTableFilters({ ...model.filters });
+                model.setChipsPopoverMessage(getPromError(errStr));


still have an issue here when a topology group is enabled. This will loop as the filters are not involved

that would make it but a bit hacky:
a1cbc9b

The positive side is that it will manage any case (not only the topology groups)

codecov · 2024-12-05T15:34:41Z

Codecov Report

Attention: Patch coverage is 31.42857% with 48 lines in your changes missing coverage. Please review.

Project coverage is 56.68%. Comparing base (01883f0) to head (3365f1c).
Report is 17 commits behind head on main.

Files with missing lines	Patch %	Lines
web/src/components/netflow-traffic.tsx	10.00%	18 Missing ⚠️
web/src/utils/errors.ts	22.72%	17 Missing ⚠️
pkg/handler/response.go	22.22%	7 Missing ⚠️
pkg/handler/topology.go	0.00%	2 Missing ⚠️
...ponents/tabs/netflow-topology/netflow-topology.tsx	33.33%	2 Missing ⚠️
web/src/components/messages/error.tsx	50.00%	1 Missing ⚠️
...b/src/components/toolbar/filters/chips-popover.tsx	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   56.70%   56.68%   -0.03%     
==========================================
  Files         197      198       +1     
  Lines       10113    10206      +93     
  Branches     1192     1203      +11     
==========================================
+ Hits         5735     5785      +50     
- Misses       4009     4055      +46     
+ Partials      369      366       -3

Flag	Coverage Δ
uitests	`59.02% <33.89%> (-0.21%)`	⬇️
unittests	`51.65% <18.18%> (+0.37%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...b/src/components/drawer/netflow-traffic-drawer.tsx	`45.54% <100.00%> (ø)`
web/src/model/netflow-traffic.ts	`86.90% <100.00%> (+0.15%)`	⬆️
web/src/components/messages/error.tsx	`21.42% <50.00%> (ø)`
...b/src/components/toolbar/filters/chips-popover.tsx	`90.00% <90.00%> (ø)`
pkg/handler/topology.go	`51.67% <0.00%> (ø)`
...ponents/tabs/netflow-topology/netflow-topology.tsx	`35.22% <33.33%> (ø)`
pkg/handler/response.go	`20.58% <22.22%> (-0.38%)`	⬇️
web/src/utils/errors.ts	`41.93% <22.72%> (-29.50%)`	⬇️
web/src/components/netflow-traffic.tsx	`63.46% <10.00%> (-3.31%)`	⬇️

... and 11 files with indirect coverage changes

github-actions · 2024-12-09T17:33:26Z

New image:
quay.io/netobserv/network-observability-console-plugin:2c90e96

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=2c90e96 make set-plugin-image

jpinsonneau · 2024-12-16T13:14:18Z

/retest

jotak

thanks, code LGTM
/lgtm

jpinsonneau · 2024-12-17T09:06:27Z

Not sure why konflux is failing here 🤔
cc @OlivierCazade

jpinsonneau · 2024-12-17T14:31:49Z

/retest

jpinsonneau · 2024-12-17T15:42:18Z

Seems like I'm always getting the following error in konflux:

[1/3] STEP 7/13: RUN . /cachi2/cachi2.env &&     CYPRESS_INSTALL_BINARY=0 node --max-old-space-size=6000 $(which npm) --legacy-peer-deps ci
npm WARN deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated [email protected]: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1
npm WARN deprecated [email protected]: core-js@<3.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
npm ERR! code ENOMEM
npm ERR! syscall spawn
npm ERR! errno -12
npm ERR! spawn ENOMEM

npm ERR! A complete log of this run can be found in: /opt/app-root/src/.npm/_logs/2024-12-17T14_47_56_250Z-debug-0.log
subprocess exited with status 244
subprocess exited with status 244
Error: building at STEP "RUN . /cachi2/cachi2.env &&     CYPRESS_INSTALL_BINARY=0 node --max-old-space-size=6000 $(which npm) --legacy-peer-deps ci": exit status 244

Amoghrd · 2024-12-23T17:25:56Z

/ok-to-test

github-actions · 2024-12-23T17:28:59Z

New image:
quay.io/netobserv/network-observability-console-plugin:270aebe

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=270aebe make set-plugin-image

Amoghrd · 2024-12-23T18:08:49Z

@jpinsonneau The page is stuck on loading when Groups are updated. Need to click on refresh button to load the page.
Also in the overview page for example if DNSTracking is enabled with no DNS metrics are select the DNS panel then the whole overview page does not load with error below. Shouldnt only that panel have that error and others should load fine right?

Otherwise PR looks good

openshift-ci · 2025-01-06T12:30:37Z

New changes are detected. LGTM label has been removed.

openshift-ci · 2025-01-06T12:30:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jpinsonneau · 2025-01-06T12:31:44Z

@jpinsonneau The page is stuck on loading when Groups are updated. Need to click on refresh button to load the page. Also in the overview page for example if DNSTracking is enabled with no DNS metrics are select the DNS panel then the whole overview page does not load with error below. Shouldnt only that panel have that error and others should load fine right?

Otherwise PR looks good

3365f1c that change will ensure groups are refreshed after an error is displayed.

However, for the Overview suggestion, this will require more changes. If you feel it's important we can open a followup.
The error shows only when the panel is selected and the metric not available which still makes sense.

Amoghrd · 2025-01-08T16:47:32Z

/ok-to-test

github-actions · 2025-01-08T16:50:47Z

New image:
quay.io/netobserv/network-observability-console-plugin:ec75f32

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ec75f32 make set-plugin-image

Amoghrd · 2025-01-08T17:38:43Z

Now changing groups works as expected.
Yeah, overview is not that important. If we get a customer case for the same then we can look at it then.
This PR is good to go.
/label qe-approved

openshift-ci bot added the do-not-merge/work-in-progress label Dec 4, 2024

jpinsonneau commented Dec 4, 2024

View reviewed changes

web/src/components/netflow-traffic.tsx Outdated Show resolved Hide resolved

auto disable filters when not available in prom

9a523da

jpinsonneau force-pushed the 1977 branch from b61a95a to 9a523da Compare December 5, 2024 15:32

jpinsonneau commented Dec 5, 2024

View reviewed changes

avoid loop

a1cbc9b

jpinsonneau marked this pull request as ready for review December 9, 2024 14:22

openshift-ci bot removed the do-not-merge/work-in-progress label Dec 9, 2024

jpinsonneau requested a review from jotak December 9, 2024 14:22

jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 9, 2024

jotak approved these changes Dec 17, 2024

View reviewed changes

openshift-ci bot assigned jotak Dec 17, 2024

openshift-ci bot added the lgtm label Dec 17, 2024

Amoghrd removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 23, 2024

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Dec 23, 2024

ensure tick recover after error

3365f1c

openshift-ci bot removed the lgtm label Jan 6, 2025

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 6, 2025

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jan 8, 2025

openshift-ci bot added the qe-approved QE has approved this pull request label Jan 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NETOBSERV-1977 automatically disable filters when not available in prometheus #662

NETOBSERV-1977 automatically disable filters when not available in prometheus #662

jpinsonneau commented Dec 4, 2024 •

edited

Loading

openshift-ci bot commented Dec 4, 2024

jpinsonneau Dec 5, 2024

jpinsonneau Dec 5, 2024

codecov bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024

jpinsonneau commented Dec 16, 2024

jotak left a comment

jpinsonneau commented Dec 17, 2024

jpinsonneau commented Dec 17, 2024

jpinsonneau commented Dec 17, 2024

Amoghrd commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

Amoghrd commented Dec 23, 2024 •

edited

Loading

openshift-ci bot commented Jan 6, 2025

openshift-ci bot commented Jan 6, 2025

jpinsonneau commented Jan 6, 2025

Amoghrd commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

Amoghrd commented Jan 8, 2025

NETOBSERV-1977 automatically disable filters when not available in prometheus #662

Are you sure you want to change the base?

NETOBSERV-1977 automatically disable filters when not available in prometheus #662

Conversation

jpinsonneau commented Dec 4, 2024 • edited Loading

Description

Dependencies

Checklist

openshift-ci bot commented Dec 4, 2024

jpinsonneau Dec 5, 2024

Choose a reason for hiding this comment

jpinsonneau Dec 5, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 5, 2024 • edited Loading

Codecov Report

github-actions bot commented Dec 9, 2024

jpinsonneau commented Dec 16, 2024

jotak left a comment

Choose a reason for hiding this comment

jpinsonneau commented Dec 17, 2024

jpinsonneau commented Dec 17, 2024

jpinsonneau commented Dec 17, 2024

Amoghrd commented Dec 23, 2024

github-actions bot commented Dec 23, 2024

Amoghrd commented Dec 23, 2024 • edited Loading

openshift-ci bot commented Jan 6, 2025

openshift-ci bot commented Jan 6, 2025

jpinsonneau commented Jan 6, 2025

Amoghrd commented Jan 8, 2025

github-actions bot commented Jan 8, 2025

Amoghrd commented Jan 8, 2025

jpinsonneau commented Dec 4, 2024 •

edited

Loading

codecov bot commented Dec 5, 2024 •

edited

Loading

Amoghrd commented Dec 23, 2024 •

edited

Loading