Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #18281: Support group assignment for virtual circuits #18291

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Closes #18281: Support group assignment for virtual circuits #18291

merged 7 commits into from
Jan 3, 2025

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Jan 2, 2025 •
edited
Loading

Closes: #18281

  • Convert the circuit ForeignKey on CircuitGroupAssignment to a generic foreign key (member)
  • Adapt Circuit & VirtualCircuit models for GFK-based group assignment
  • Rearrange navigation menu to list circuit groups separately

@jeremystretch jeremystretch marked this pull request as ready for review January 2, 2025 20:00
@jeremystretch jeremystretch merged commit c3b0de3 into feature Jan 3, 2025
6 checks passed
@jeremystretch jeremystretch deleted the 18281-virtual-circuit-group branch January 3, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bctiemann bctiemann bctiemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremystretch @bctiemann