Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Virtual Circuits to be assigned to groups #18281

Closed
sleepinggenius2 opened this issue Dec 30, 2024 · 0 comments
Closed

Allow Virtual Circuits to be assigned to groups #18281

sleepinggenius2 opened this issue Dec 30, 2024 · 0 comments
Assignees
@jeremystretch
Labels
beta Concerns a bug/feature in a beta release complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@sleepinggenius2
Copy link
Contributor

NetBox version

v4.2-beta1

Feature type

Data model extension

Triage priority

N/A

Proposed functionality

Allow for Virtual Circuits to also be assigned to groups. I believe it's sufficient to use the existing Circuit Groups and only change the Circuit Group Assignment model to allow for selecting a Circuit or Virtual Circuit, as a given group might have a mix.

Use case

We have public cloud connectivity through both a direct connection and a backup VPN connection, so it would be nice to document the (physical) Circuit for the direct connection with a primary priority and a Virtual Circuit for the VPN with a secondary priority within the same Circuit Group. In other places, we have multiple (usually two) Virtual Circuits between locations on different VLANs and diverse paths, which we designate with different priorities. Just like we can document (physical) Circuits in this way, we should be able to do the same with Virtual Circuits.

Database changes

Either add a virtual_circuit field that is a ForeignKey to the VirtualCircuit model or change the existing circuit field to be a GenericForeignKey on the CircuitGroupAssignment model.

External dependencies

None
@sleepinggenius2 sleepinggenius2 added status: needs triage This issue is awaiting triage by a maintainer type: feature Introduction of new functionality to the application labels Dec 30, 2024
@jeremystretch jeremystretch added the beta Concerns a bug/feature in a beta release label Dec 30, 2024
@jeremystretch jeremystretch self-assigned this Dec 30, 2024
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation complexity: medium Requires a substantial but not unusual amount of effort to implement and removed status: needs triage This issue is awaiting triage by a maintainer labels Dec 30, 2024
@jeremystretch jeremystretch mentioned this issue Jan 2, 2025
Merged
jeremystretch added a commit that referenced this issue Jan 3, 2025
@jeremystretch
Closes #18281: Support group assignment for virtual circuits (#18291)
c3b0de3 
* Rename circuit to member on CircuitGroupAssignment

* Support group assignment for virtual circuits

* Update release notes

* Introduce separate nav menu heading for circuit groups

* Add generic relations for group assignments

* Remove obsolete code

* Clean up bulk import & extend tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremystretch jeremystretch

Labels
beta Concerns a bug/feature in a beta release complexity: medium Requires a substantial but not unusual amount of effort to implement status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremystretch @sleepinggenius2