Fix contact groups #1481
Open
Fix contact groups #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several places in `netbox_utils.py` that referred to `contact_groups` for no apparent reason, and some that referred to `contact_group` despite the feature being buggy (see netbox-community#1182). As a contact can belong to multiple groups, I think `contact_groups` makes more sense, and fixes the bugggy behavior.
Contributor
Author
|
I just discovered that https://github.com/netbox-community/netbox/releases/tag/v4.3.0 changed |
Contributor
Author
|
Not sure why CI linting failed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #1182
New Behavior
Netbox 4.3.0 changed the
Contact.contact_groupcolumn toContact.contact_groups, which subtly broke thenetbox_contactmodule.netbox_contactmodule, add thecontact_groupsfield alongside the existingcontact_group.*
Contrast to Current Behavior
To add a contact to a contact group, you must now use one of two fields:
contact_grouporcontact_groups, depending on your Netbox version. An informative error will be thrown if you use the wrong one.Discussion: Benefits and Drawbacks
Anyone who used the workarounds described in #1182 will probably need to update their playbooks.
The new API is much nicer IMHO.
Changes to the Documentation
No changes besides the updated auto module docs. The
contact_group/contact_groupsfields document which Netbox versions are valid.Proposed Release Note Entry
Change
netbox_contacts.contact_grouptocontact_groups(see #1182)Double Check
develbranch.