[client] Use native facilities to add routes on BSD and Windows

[lixmal]

Describe your changes

• Use syscalls to add/remove routes on Windows
• Use the routing socket to add/remove routes on BSD variants
• Replace net.IP and net.IPNet with netip.Addr and netip.Prefix in wgaddr.Address
• Fix some tests for FreeBSD
• Remove "add route for gateway" and "duplicate route" logic
• Add allowed route validation
• Add better tests

Issue ticket number and link

Stack

Checklist

• Is it a bug fix
• Is a typo/documentation fix
• Is a feature enhancement
• It is a refactor
• Created tests that fail without the change (if possible)
• Extended the README / documentation, if necessary

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

[Copilot]

Pull Request Overview

This PR replaces use of external route commands on Windows with direct IP Helper syscalls to manage routing entries.

• Introduces addRoute, deleteRoute, and helper functions to set up MIB_IPFORWARD_ROW2 via Windows APIs
• Removes exec-based command logic and related imports
• Adds syscall wrappers for creating, deleting, and querying route entries

Comments suppressed due to low confidence (3)

client/internal/routemanager/systemops/systemops_windows.go:3

• New code uses fmt.Errorf, binary.BigEndian, and unsafe.Pointer but the imports for "fmt", "encoding/binary", and "unsafe" are missing. Please add these imports to ensure the file compiles.

import (

client/internal/routemanager/systemops/systemops_windows.go:327

• [nitpick] The function name uses the acronym "LUID" while the type is declared as lowercase luid. Consider renaming the type to LUID or the function to convertInterfaceIndexToLuid for consistency with Go naming conventions.

func convertInterfaceIndexToLUID(interfaceIndex uint32, interfaceLUID *luid) error {

client/internal/routemanager/systemops/systemops_windows.go:192

• New addRoute (and related syscall wrappers) lack unit tests. Consider adding tests or mocks to verify both successful execution paths and error handling.

func addRoute(prefix netip.Prefix, nexthop Nexthop) (err error) {

[pappz]

@lixmal, please merge the main branch to fix the unit tests.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud