Skip to content

feat(microservices): nats v3 upgrade #15190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Upgrade to nats v3

What is the current behavior?

Issue Number: #15050

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build d23343fc-9088-4892-9091-dc67809053b8

Details

  • 17 of 24 (70.83%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 88.904%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-nats.ts 6 9 66.67%
packages/microservices/server/server-nats.ts 7 11 63.64%
Files with Coverage Reduction New Missed Lines %
packages/microservices/client/client-nats.ts 1 76.85%
packages/microservices/server/server-nats.ts 1 75.24%
Totals Coverage Status
Change from base Build 3e5abc62-0084-4afd-9980-fd1c78cb151b: -0.04%
Covered Lines: 7179
Relevant Lines: 8075

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants