Skip to content

refactor(core,express,fastify): HTTP adapter error mapping #15075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxbronnikov10
Copy link

@maxbronnikov10 maxbronnikov10 commented May 5, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

FastifyError instance did not mapped to HttpException which broke conditions in ExceptionFilter in core package.

Issue Number: #15022

What is the new behavior?

Added mapping function to abstract http adapter that overrided in express and fastify

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

coveralls commented May 5, 2025

Pull Request Test Coverage Report for Build 8f9992ff-9783-48dd-888a-83dfed01bbc7

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 88.931%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/router/routes-resolver.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 0ff12a80-22b7-43a2-8e8a-1d5a5d5d96fc: -0.007%
Covered Lines: 7191
Relevant Lines: 8086

💛 - Coveralls

@maxbronnikov10 maxbronnikov10 force-pushed the refactor/http-adapter-error branch from 3589b96 to 7229861 Compare May 8, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants