Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rust-toolchain from 1.81.0 to 1.85.0, Upgrade rust edition from 2021 to 2024 #4818

Merged
merged 22 commits into from
Mar 5, 2025
Merged

Upgrade rust-toolchain from 1.81.0 to 1.85.0, Upgrade rust edition from 2021 to 2024 #4818

merged 22 commits into from
Mar 5, 2025

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Feb 24, 2025 •
edited
Loading

What problem does this PR solve?

Waiting:

What's Changed:

Related changes

  • Upgrade rust-toolchain from 1.81.0 to 1.85.0
  • Upgrade rust edition from 2021 to 2024

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad mentioned this pull request Feb 24, 2025
Closed
@eval-exec eval-exec changed the title Upgrade rust-toolchain to 1.85.0, Upgrade rust edition from 2021 to 2024 Upgrade rust-toolchainfrom 1.81.0 to 1.85.0, Upgrade rust edition from 2021 to 2024 Feb 24, 2025
@eval-exec eval-exec changed the title Upgrade rust-toolchainfrom 1.81.0 to 1.85.0, Upgrade rust edition from 2021 to 2024 Upgrade rust-toolchain from 1.81.0 to 1.85.0, Upgrade rust edition from 2021 to 2024 Feb 27, 2025
@eval-exec eval-exec force-pushed the exec/upgrade-toolchain-1.85.0 branch from 3310c29 to 66dcc09 Compare March 1, 2025 08:07
@eval-exec eval-exec marked this pull request as ready for review March 1, 2025 08:08
@eval-exec eval-exec requested a review from a team as a code owner March 1, 2025 08:08
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team March 1, 2025 08:08
@eval-exec eval-exec force-pushed the exec/upgrade-toolchain-1.85.0 branch from 66dcc09 to d3958d3 Compare March 1, 2025 08:11
@eval-exec eval-exec force-pushed the exec/upgrade-toolchain-1.85.0 branch 3 times, most recently from 3b482c9 to ad0c5ad Compare March 1, 2025 08:19
eval-exec added 12 commits March 1, 2025 16:25
@eval-exec
chore: reword document comment prefix
04f2f4c 
Signed-off-by: Eval EXEC <[email protected]>
@eval-exec
clippy: allow needless_lifetimes: https://rust-lang.github.io/rust-cl…
36154e6 
…ippy/master/index.html#/needless_lifetime
@eval-exec
clippy: pacnic::PanicInfo is deprecated, sue PanicHookInfo
1fdedb1
@eval-exec
clippy: add crate documentation for logger-service
1bb4db4
@eval-exec
clippy: use div_ceil: https://rust-lang.github.io/rust-clippy/master/…
8d6e535 
…index.html#manual_div_ceil
@eval-exec
clippy: remove needless type conversion
4c703b6
@eval-exec
clippy: fix precedence and apply clippy suggests to add parentheses
567079c
@eval-exec
clippy: rename Setup::gen to Setup::generate since gen is a res…
0105617 
…erved rust keyword: https://doc.rust-lang.org/edition-guide/rust-2024/gen-keyword.html
@eval-exec
clippy: Use rust 2021 for ckb-gen-types since https://doc.rust-lang.o…
445e907 
…rg/nightly/edition-guide/rust-2024/match-ergonomics.html
@eval-exec
clippy: fix rust 2024 match-ergonomics https://doc.rust-lang.org/nigh…
a6fbabf 
…tly/edition-guide/rust-2024/match-ergonomics.html
@eval-exec
clippy: std::env::set_var is unsafe
8309296
@eval-exec
clippy: Use rust 2021 for ckb-jsonrpc-types since 3rd crate schemars …
4953fce 
…have gen keyword as identifier
@eval-exec eval-exec force-pushed the exec/upgrade-toolchain-1.85.0 branch 2 times, most recently from 2ddc471 to 83583da Compare March 1, 2025 08:32
eval-exec added 6 commits March 3, 2025 15:23
@eval-exec
clippy: remove ref mut in ckb-resources
69a26a5
@eval-exec
clippy: binding modifier not allowed under ref default binding mode
8ac4a57
@eval-exec
clippy: use unsafe to wrap env::set_var is unsafe
0e4730d 
Signed-off-by: Eval EXEC <[email protected]>
@eval-exec
clippy: Allow elided lifetime has a name in chain_controller
902a999 
warning: elided lifetime has a name
   --> chain/src/chain_controller.rs:127:43
    |
33  | #[cfg_attr(feature = "mock", faux::methods)]
    |                              ------------- lifetime `'m` declared here
...
127 |     pub fn get_orphan_block(&self, store: &ChainDB, hash: &Byte32) -> Option<Arc<BlockView>> {
    |

Signed-off-by: Eval EXEC <[email protected]>
@eval-exec
rustfmt: execute cargo fmt
c815258 
Signed-off-by: Eval EXEC <[email protected]>
@eval-exec
CI: use rust 2024 version of cargo-shear on MacOS CI workflows
cfddf9c 
Signed-off-by: Eval EXEC <[email protected]>
@eval-exec eval-exec force-pushed the exec/upgrade-toolchain-1.85.0 branch from 83583da to cfddf9c Compare March 3, 2025 07:23
@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 5, 2025
@eval-exec eval-exec removed this pull request from the merge queue due to a manual request Mar 5, 2025
@eval-exec eval-exec added this pull request to the merge queue Mar 5, 2025
Merged via the queue into nervosnetwork:develop with commit 55035c8 Mar 5, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eval-exec @zhangsoledad