Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delayed 2nd hardfork testnet activation #4326

Merged
merged 1 commit into from
Jan 26, 2024
Merged

chore: delayed 2nd hardfork testnet activation #4326

merged 1 commit into from
Jan 26, 2024

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Jan 26, 2024 •
edited
Loading

What problem does this PR solve?

This reverts commit f2890df.
2nd hardfork still needs some tweaking:

  • We need to consider whether to keep A extension
  • Spawn syscall needs more time to refine its design.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@zhangsoledad zhangsoledad requested a review from a team as a code owner January 26, 2024 02:46
@zhangsoledad zhangsoledad requested review from quake and removed request for a team January 26, 2024 02:46
@eval-exec eval-exec added the b:consensus Break consensus label Jan 26, 2024
@quake quake added this pull request to the merge queue Jan 26, 2024
Merged via the queue into nervosnetwork:develop with commit 952153b Jan 26, 2024
33 checks passed
@zhangsoledad zhangsoledad deleted the zhangsoledad/delayed-testnet-activation branch January 26, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@eval-exec eval-exec eval-exec approved these changes

Assignees
No one assigned
Labels
b:consensus Break consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhangsoledad @quake @eval-exec