Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around failing to start nerves_key when optional dep #55

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Work around failing to start nerves_key when optional dep #55

merged 1 commit into from
Dec 7, 2020

Conversation

jjcarstens
Copy link
Collaborator

In response to #52

@fhunleth
Copy link
Contributor

fhunleth commented Dec 5, 2020

How about putting the Application.ensure_all_started in the NervesKey configurator? Then there's no need for the if.

@fhunleth fhunleth merged commit d9a56c1 into main Dec 7, 2020
@fhunleth fhunleth deleted the start-nerves_key branch December 7, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhunleth fhunleth fhunleth approved these changes

@mobileoverlord mobileoverlord Awaiting requested review from mobileoverlord

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjcarstens @fhunleth