Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tracking total network traffic #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshk
Copy link
Contributor

@joshk joshk commented Jan 24, 2025

This sends the total bytes sent and received for each interface, except local.

One thing we should think about is how to track the delta.

A potential issue I anticipate is a connection crashing, making it look like the device has consumed a lot of data from its first report.

I wonder if we should track the previous total in link and only send the delta. If there is no previous total, we send zeros.

But the downside of this is that if a report isn't received and processed, we will miss some data. Sooooo maybe, we send totals, but we cache the first report and use that for the baseline for future reports.

@joshk joshk force-pushed the device-health-network-traffic branch from 15c9b61 to 83c99e3 Compare January 24, 2025 04:15
@lawik
Copy link
Contributor

lawik commented Jan 24, 2025

For now I think totals is a great start with warts and all. These also wrap back around to 0 at ~4Gb.

We can make something more nuanced later.

This was on my list, super that you got to it :)

@lawik
Copy link
Contributor

lawik commented Jan 24, 2025

Since this is one of the default things we offer we can try to be a bit smart and summarize them similar to Load averages or something on the primary Health display (Device Details view). And we can have an information icon to hover that explains the data and how it might behave a little bit. Give some context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants