Use Alarmist for current alarms in default health report #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinol
force-pushed
the
use-alarmist-in-default-health-report
branch
from
4425a10 to
afe5c89
Compare
elinol
commented
Jan 7, 2025
Comment on lines
27
to
41
| try do | ||
| module = String.to_existing_atom("Elixir.Alarmist") | ||
| alarms = apply(module, :get_alarms, []) | ||
|
|
||
| for {id, description} <- alarms, into: %{} do | ||
| try do | ||
| {inspect(id), inspect(description)} | ||
| catch | ||
| _, _ -> | ||
| {"bad alarm term", ""} | ||
| end | ||
| end | ||
| rescue | ||
| _ -> %{} | ||
| end |
There was a problem hiding this comment.
I don't really like these nested try, have to cover for cases when Alarmist is not available. Any other takes on this?
There was a problem hiding this comment.
Maybe something like this is better:
@impl Report
def alarms() do
# Currently, only Alarmist is supported as alarm handler.
# Send empty map if Alarmist isn't loaded.
alarms =
try do
apply(Alarmist, :get_alarms)
rescue
_ -> %{}
end
for {id, description} <- alarms, into: %{} do
try do
{inspect(id), inspect(description)}
catch
_, _ ->
{"bad alarm term", ""}
end
end
end
Credo is complaining on using apply though.
There was a problem hiding this comment.
I think we can use some compile-time power here:
if Code.ensure_loaded?(Alarmist) do
def alarms() do
# .. the things
end
else
def alarms() do
%{}
end
end
lawik
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.