Skip to content

Upgrade to babel7#6

Open
DannyvanHolten wants to merge 1 commit intonerdchacha:masterfrom
DannyvanHolten:master
Open

Upgrade to babel7#6
DannyvanHolten wants to merge 1 commit intonerdchacha:masterfrom
DannyvanHolten:master

Conversation

@DannyvanHolten
Copy link

Hey hey,

I want to keep using react-hoverintent as it works nicely. But since we've upgraded to babel7 our corejs is duplicated since you still use corejs 1. I've upgraded to babel7 which fixed the problem. Please let me know if you can implement this :)

@nerdchacha
Copy link
Owner

Hey @DannyvanHolten ,

First of all, thanks for creating the pull request.
I might have lost track of this project but I would need some time to look at the PR and maybe add a few test cases to make the PR process a bit smooth ever for the changes in future.

As a work around, I would recommend you to use
import HoverIntet from './node_modules/react-hoverintent/src/components' (I know this looks counter intuitive).

What this will do is let you build the component as per your build pipeline and babel version and you should be able to use it with babel 7 for now.

I would like to come up with a way to let the users import the raw component (not transpiled) somehow to let them run it through their own pipeline.

Let me know if that helps.

Cheers,
Yatin

@DannyvanHolten
Copy link
Author

For now that does help :) Thanx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants