Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct version to v4.0.0 #226

Open
wants to merge 1 commit into
base: R4
Choose a base branch
from
Open

Correct version to v4.0.0 #226

wants to merge 1 commit into from

Conversation

debeaueric
Copy link
Contributor

No description provided.

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tliron for approval by writing /assign @tliron in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Mar 17, 2025 •
edited
Loading

✅ Deploy Preview for nephio-r4 ready!

Name Link
🔨 Latest commit cefbf1f
🔍 Latest deploy log https://app.netlify.com/sites/nephio-r4/deploys/67d88e0ad18ab300081140d3
😎 Deploy Preview https://deploy-preview-226--nephio-r4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

efiacor
efiacor reviewed Mar 18, 2025
View reviewed changes
content/en/docs/guides/install-guides/common-dependencies.md
@@ -33,7 +33,7 @@ This component is a controller for applying configuration to routers and
switches.

```bash
kpt pkg get --for-deployment https://github.com/nephio-project/catalog.git/nephio/optional/network-config@origin/v3.0.0
kpt pkg get --for-deployment https://github.com/nephio-project/catalog.git/nephio/optional/network-config@origin/v4.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am leaning towards removing the vX.Y.Z refs in the docs altogether and just using a place holder. It would require some refactoring and an explainer regarding the released versions available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should go with this change from @debeaueric for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiacor efiacor efiacor left review comments

@CsatariGergely CsatariGergely Awaiting requested review from CsatariGergely

@liamfallon liamfallon Awaiting requested review from liamfallon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debeaueric @liamfallon @efiacor