Skip to content

feat(lua_ls): add rootPath to workspace.library #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mo-tmd
Copy link

@Mo-tmd Mo-tmd commented Apr 27, 2025

This seems to make it possible to jump to any lua file under rootPath, regardless of directory structure.

I'm a noob in this area, please let me know if there's anything strange.

@Mo-tmd Mo-tmd requested a review from glepnir as a code owner April 27, 2025 18:28
@Mo-tmd Mo-tmd force-pushed the master branch 4 times, most recently from d16d96b to 6953f0c Compare April 27, 2025 18:42
This seems to make it possible to jump to any file regardless of
project structure.
@Mo-tmd Mo-tmd changed the title featu(lua_ls): Add rootPath to workspace.library feat(lua_ls): add rootPath to workspace.library Apr 27, 2025
@antonk52

This comment was marked as resolved.

@Mo-tmd
Copy link
Author

Mo-tmd commented May 1, 2025

I think this is better suited in the docs to make lua_ls more suitable for neovim configuration. This should not be in the default settings as not every lua project opened in neovim is a neovim configuration.

Why do you think this is a neovim specific configuration?

@antonk52
Copy link
Contributor

antonk52 commented May 1, 2025

Please ignore my comment. For some reason I thought it was injecting runtime path, which is clearly not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants