TASK: Harden new gh e2e tests, use pull_request.#4091
Open
TASK: Harden new gh e2e tests, use pull_request.#4091
pull_request.#4091Conversation
…ets` Currently we use the workaround via `pull_request_target` to provide access to our secret in forks. This is more dangerous than exposing the one api key as variable. For example in case a new gh-secret is added which should really be kept secret. Before storing the variable really really plain we obfuscate it a little though the encryption password is in the source code, so anyone can retrieve it. But the bes they can do is run e2e tests on saucelabs - so happy testing?:D ``` echo "the-key" | openssl enc -e -des3 -base64 -pass pass:neos -pbkdf2 ``` Also `pull_request_target` does not work properly as tests are always run with neos-version: '9.1' - the highest - instead of the appropriate version by branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it