WIP: POC: refactor node tree using query dtos#3944
Draft
WIP: POC: refactor node tree using query dtos#3944
Conversation
New name "@neos-project/neos-use" aupair with "react-use". - Adjusted to the correct `dependencies` - now uses the neos context and redux react context directly instead of booting a custom one - useI18n was removed in favour of the `translate` function - removed lots of plugin specific workaround that are not necessary as part of the core code like typescript stubs etc.
New name "@neos-project/neos-node-tree". - Adjusted to the correct `dependencies` - now uses the neos context and redux react context directly instead of booting a custom one - useI18n was removed in favour of the `translate` function - removed lots of plugin specific workaround that are not necessary as part of the core code like typescript stubs etc.
... initialisation fails because of
Absolute node paths must serialized beginning with the pattern \"\/<My.Package:Root>\" ,\"{\"contentRepositoryId\":\"onedimension\",\"workspaceName\":\"admin-admington\",\"dimensionSpacePoint\":{\"language\":\"en_US\"},\"aggregateId\":\"f676459d-ca77-44bc-aeea-44114814c279\"}\" does not"
…ntext path a node address is not an absolute node path - that failed before
Member
|
Cool, but what issue is resolved with this? What is the benefit? Do you have something to link to? :) |
Member
Author
|
We discussed during the development meetings that we want to try this out to see if the tree is more performant and better maintainable. Putting the load on the server is a pattern we started using already for some things which is more explained here in this POC #3331 A full description of the code this change is based on can be found here sitegeist/Sitegeist.Archaeopteryx#63 |
|
I guess yarn cache files should not be commited |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a dinosaur , so it must be good.
What I did
How I did it
How to verify it