BUGFIX: 3839 show warn dialog before ckeditor formatting gets lost#3842
Draft
BUGFIX: 3839 show warn dialog before ckeditor formatting gets lost#3842
Conversation
grebaldi
suggested changes
Aug 28, 2024
Contributor
grebaldi
left a comment
grebaldi
left a comment
There was a problem hiding this comment.
Looks good after a first quick skim, but I noticed a naming issue:
derivation, *Derivation should be deviation, *Deviation, because
| English | German |
|---|---|
| derivation | Ableitung |
| deviation | Abweichung |
mhsdesign
force-pushed
the
bugfix/3839-ckeditor-warn-dialog-before-formatting-getting-lost
branch
from
be5ca0f to
c40ef35
Compare
mhsdesign
changed the base branch from
8.3
to
bugfix/3839-ckeditor-only-save-changes-if-dirty
github-actions
bot
added
bugfix/3839-ckeditor-only-save-changes-if-dirty
and removed
8.3
labels
Base automatically changed from
bugfix/3839-ckeditor-only-save-changes-if-dirty
to
8.3
September 9, 2024 11:09
github-actions
bot
added
8.3
and removed
bugfix/3839-ckeditor-only-save-changes-if-dirty
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #3839
Bildschirmaufnahme.2024-08-26.um.16.03.48.mov
What I did
How I did it
How to verify it