Repository navigation
TASK: Drop overridden constructors for TestCase again - #3638
Merged
dlubitz merged 1 commit intoOct 16, 2026
Merged
Conversation
They were removed in 26b8b11, but a later Rector run re-added them (`ParentTestClassConstructorRector` from `PHPUnitSetList::PHPUNIT_100` targets `TestCase` subclasses without a `Test` suffix). `TestCase::__construct()` is final since PHPUnit 12.1, so loading `PersistenceTestPHP8` breaks the functional test bootstrap with "Cannot override final method". The override also replaced the test method name with the class name.
Contributor
Author
|
Worked back in May, may work again :) @kdambekalns |
kdambekalns
approved these changes
Oct 16, 2026
Contributor
Author
|
Thanks for the fast reviews guys 🥇 |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were removed in 26b8b11, but a later Rector run re-added them (
ParentTestClassConstructorRectorfromPHPUnitSetList::PHPUNIT_100targetsTestCasesubclasses without aTestsuffix).TestCase::__construct()is final since PHPUnit 12.1, so loadingPersistenceTestPHP8breaks the functional test bootstrap with "Cannot override final method". The override also replaced the test method name with the class name.