[mficzel]

Upgrade phpstan from ~1.2 to ~2.2 ...

Upgrade instructions

Review instructions

After successfull review, before merge the following adjustments are required:

• add phpstan ^2.2 constraint t to flow-dev-distribution
• add phpstan ^2.2 constraint to neos-dev-distribution
• remove explicit composer require --no-update phpstan/phpstan:"~2.2" from .github/actions/prepare-flow/action.yml

Also note that raising the phpstan requirement to 2.2 will also trigger issues on the neos side that need adjustment at the same time.

Checklist

• Code follows the PSR-12 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[mficzel]

I made this a draft for now to prevent merging to 9.2 ... this should go to 9.3

[mficzel]

@nezaniel @mhsdesign ... would be great to get preliminary feedback on this. Would like to start working on the Neos side but this only makes sense if the framework changes are kinda final.

With this change and phpstan 2.2 the run un neos yields: "Found 298 errors" :-/

[mficzel]

While this is clearly true it also triggers follow up adjustments.
On the other hand it is not a functional change at all. Just an annotation.

[mficzel]

Checked again and processRequest and callActionMethod handle the case of view beeing null kindoff. I think typing this as ViewInterface|null is the only honest option.

[mhsdesign]

why not isset($this->view)

or people should just write $this->view?->assign() in their controller but that sucks too - on the other-hand i dont use views and the action controller anymore at all or i trie as everything is rusty either way

[mficzel]

i think $this->view?->assign() is the best way ... but not really elegant