Decouple the flush path from the read path #12840
Open
+272
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, flushing the EphemeralFile to disk held a write lock on the struct. During slow disk IO (10ms - 50ms+), this blocked all concurrent readers (GetPage), causing latency spikes and throughput collapse.
See #12172 for the full context.
Summary of changes
arc_swap::ArcSwapto publish the frozen buffer atomically. Readers access it wait-free.disk_committed_offsetto distinguish between data in the buffer vs. disk, preventing race conditions.writer_lockto serialize concurrent writers (WAL append-only integrity) without blocking readers.Verification & Benchmarks (Local NVMe + Synthetic 50ms Latency):