Skip to content

Conversation

@skyzh
Copy link
Contributor

@skyzh skyzh commented Jul 23, 2025

Problem

  • we cannot use dbdir unfortunately.
  • one more read, but we can cache it (in next few patches).

Summary of changes

  • index_part.json is no longer used for reldir migration status, will clean up in the future.
  • we store the migration status in a key in the reldir sparse keyspace.
  • new rel_size_v1_access_disabled field to completely disable v1 writes and reads.
  • adjust test cases accordingly.
  • enable reldirv2 in tests by default.

@github-actions
Copy link

github-actions bot commented Jul 23, 2025

9053 tests run: 8356 passed, 47 failed, 650 skipped (full report)


Failures on Postgres 17

Failures on Postgres 16

Failures on Postgres 15

Failures on Postgres 14

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_fully_custom_config[release-pg14] or test_fully_custom_config[release-pg14] or test_image_consistent_lsn[release-pg14] or test_image_consistent_lsn[release-pg14] or test_pg_regress[release-pg14-v2-4] or test_pg_regress[release-pg14-v2-4] or test_pg_regress[release-pg14-v2-None] or test_pg_regress[release-pg14-v2-None] or test_fully_custom_config[release-pg15] or test_fully_custom_config[release-pg15] or test_image_consistent_lsn[release-pg15] or test_image_consistent_lsn[release-pg15] or test_pg_regress[release-pg15-v2-None] or test_pg_regress[release-pg15-v2-None] or test_pg_regress[release-pg15-v2-4] or test_pg_regress[release-pg15-v2-4] or test_fully_custom_config[release-pg16] or test_fully_custom_config[release-pg16] or test_image_consistent_lsn[release-pg16] or test_image_consistent_lsn[release-pg16] or test_pg_regress[release-pg16-v2-None] or test_pg_regress[release-pg16-v2-None] or test_pg_regress[release-pg16-v2-4] or test_pg_regress[release-pg16-v2-4] or test_fully_custom_config[release-pg17] or test_fully_custom_config[release-pg17] or test_fully_custom_config[debug-pg17] or test_fully_custom_config[release-pg17] or test_fully_custom_config[release-pg17] or test_image_consistent_lsn[release-pg17] or test_image_consistent_lsn[release-pg17] or test_image_consistent_lsn[debug-pg17] or test_image_consistent_lsn[release-pg17] or test_pg_regress[release-pg17-v2-None] or test_pg_regress[release-pg17-v2-None] or test_pg_regress[release-pg17-v2-None] or test_pg_regress[debug-pg17-v2-None] or test_pg_regress[release-pg17-v2-None] or test_pg_regress[release-pg17-v2-4] or test_pg_regress[release-pg17-v2-4] or test_pg_regress[release-pg17-v2-4] or test_pg_regress[release-pg17-v2-4] or test_pg_regress[debug-pg17-v2-4] or test_sql_regress[debug-pg17-v1-4] or test_sql_regress[debug-pg17-v2-4] or test_sql_regress[debug-pg17-v1-None] or test_sql_regress[debug-pg17-v2-None]"
Flaky tests (10)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Test coverage report is not available

The comment gets automatically updated with the latest test results
13b84d8 at 2025-07-28T21:00:32.771Z :recycle:

@skyzh skyzh force-pushed the skyzh/try-reldirv2-test branch 2 times, most recently from b702cdd to ceb2549 Compare July 23, 2025 20:38
@skyzh skyzh changed the title feat(pageserver): enable reldirv2 by default in regress tests feat(pageserver): store reldirv2 migration in key Jul 24, 2025
@skyzh skyzh force-pushed the skyzh/try-reldirv2-test branch from ab8cefc to 64ff3d0 Compare July 25, 2025 21:18
@skyzh skyzh force-pushed the skyzh/try-reldirv2-test branch from 64ff3d0 to 0c8a715 Compare July 28, 2025 19:21
Signed-off-by: Alex Chi Z <[email protected]>
@skyzh
Copy link
Contributor Author

skyzh commented Jul 30, 2025

closing in favor of #12758

@skyzh skyzh closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants