Skip to content

Commit

Permalink
Fix clippy warning on macOS (#10282)
Browse files Browse the repository at this point in the history
## Problem

On macOS:

```
error: unused variable: `disable_lfc_resizing`
   --> compute_tools/src/bin/compute_ctl.rs:431:9
    |
431 |         disable_lfc_resizing,
    |         ^^^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `disable_lfc_resizing: _`
    |
    = note: `-D unused-variables` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_variables)]`
```

## Summary of changes
- Initialise `disable_lfc_resizing` only on Linux (because it's used on
Linux only in further bloc)
  • Loading branch information
bayandin authored Jan 6, 2025
1 parent ad7f14d commit 02f81b6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions compute_tools/src/bin/compute_ctl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,7 @@ fn start_postgres(
let &ComputeSpec {
swap_size_bytes,
disk_quota_bytes,
#[cfg(target_os = "linux")]
disable_lfc_resizing,
..
} = &state.pspec.as_ref().unwrap().spec;
Expand Down

1 comment on commit 02f81b6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7377 tests run: 7014 passed, 1 failed, 362 skipped (full report)


Failures on Postgres 16

  • test_storage_controller_many_tenants[github-actions-selfhosted]: release-x86-64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_storage_controller_many_tenants[release-pg16-github-actions-selfhosted]"
Flaky tests (3)

Postgres 17

Postgres 16

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-x86-64

Postgres 14

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-x86-64

Code coverage* (full report)

  • functions: 31.2% (8410 of 26962 functions)
  • lines: 48.0% (66787 of 139234 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
02f81b6 at 2025-01-06T22:30:38.975Z :recycle:

Please sign in to comment.