Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Deno specific tests in Core #1074

Open
wants to merge 1 commit into
base: 5.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"build::notci": "lerna bootstrap",
"docs": "lerna run docs --stream --concurrency 1",
"test::unit": "lerna run test::unit --stream",
"test::deno": "lerna run test::deno --stream",
"test::integration": "lerna run test::integration --stream",
"test::browser": "lerna run test::browser --stream",
"test::stress": "lerna run test::stress --stream",
Expand Down
7 changes: 4 additions & 3 deletions packages/core/jest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,10 @@ export default {
// ],

// An array of regexp pattern strings that are matched against all test paths, matched tests are skipped
// testPathIgnorePatterns: [
// "/node_modules/"
// ],
testPathIgnorePatterns: [
"/node_modules/",
"/test/deno/"
bigmontz marked this conversation as resolved.
Show resolved Hide resolved
],

// The regexp pattern or array of patterns that Jest uses to detect test files
// testRegex: [],
Expand Down
1 change: 1 addition & 0 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"test": "jest",
"test::watch": "jest --watch",
"test::unit": "npm run test",
"test::deno": "deno test --allow-none ./test/deno/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might worth to remove the flag --allow-none after you create testing code under ./test/deno/.

"predocs": "npm run build && npm run build::es6",
"docs": "esdoc -c esdoc.json",
"prepare": "npm run build",
Expand Down
Empty file.
3 changes: 3 additions & 0 deletions testkit/unittests.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@

run_in_driver_repo(["npm", "run", "lint"])
run_in_driver_repo(["npm", "run", "test::unit", "--", ignore])

if is_deno():
run_in_driver_repo(["npm" "run", "test::deno"])