Skip to content

Conversation

@kalrasamridhi7
Copy link
Contributor

@kalrasamridhi7 kalrasamridhi7 commented Oct 25, 2025

Description

This PR implements tool calling functionality from LLMInterface for Ollama. Also provides an example for it.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Complexity: Medium

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@kalrasamridhi7 kalrasamridhi7 requested a review from a team as a code owner October 25, 2025 15:52
@kalrasamridhi7
Copy link
Contributor Author

@CodiumAI-Agent /update_changelog

@QodoAI-Agent
Copy link

Changelog updates: 🔄

2025-10-25 *

Added

  • Tool calling support for Ollama in LLMInterface, including sync/async APIs
  • Example demonstrating Ollama tool calls and updated examples index

Tested

  • Unit tests and manual testing for new Ollama tool calling functionality

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@kalrasamridhi7 kalrasamridhi7 force-pushed the skalra/ollama-tool-calling branch from 2e4d5e7 to e0b5aca Compare October 25, 2025 17:42
@stellasia
Copy link
Contributor

Hi @kalrasamridhi7 ,
Thanks for this work! I saw you signed the CLA (thanks for this too), we're going to add you to the whitelist and process with the review shortly.

@QodoAI-Agent
Copy link

Changelog updates: 🔄

Added

  • Tool calling support for Ollama in the LLM interface, with synchronous and asynchronous examples.
  • Unit tests covering Ollama tool calling behavior.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@kalrasamridhi7
Copy link
Contributor Author

Hi @stellasia, thanks for getting back. Awaiting review!

Copy link
Contributor

@stellasia stellasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, thank you for taking the time to contribute! I left a few comments, the use of options to set the model temperature is the most important.

@kalrasamridhi7 kalrasamridhi7 force-pushed the skalra/ollama-tool-calling branch from e0b5aca to 0621f04 Compare December 27, 2025 13:03
@kalrasamridhi7
Copy link
Contributor Author

Thanks for the review, @stellasia! Sorry for getting back late. I have addressed all your comments.

@stellasia
Copy link
Contributor

Hi @kalrasamridhi7 ,
Thanks a lot for that! CI is failing due to some file formating but once this is fixed we'll be able to merge this PR 🎉

@kalrasamridhi7 kalrasamridhi7 force-pushed the skalra/ollama-tool-calling branch from 0621f04 to 12b0521 Compare January 8, 2026 13:44
@kalrasamridhi7
Copy link
Contributor Author

kalrasamridhi7 commented Jan 8, 2026

Previous tests were failing due to Ruff formatter checks. Fixed and changes pushed.

Copy link
Contributor

@stellasia stellasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing @kalrasamridhi7 !

@stellasia stellasia merged commit 92f4b14 into neo4j:main Jan 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants