Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications for WAIT commands #231

Merged
merged 13 commits into from
Dec 11, 2024

Conversation

l-heemann
Copy link
Contributor

@l-heemann l-heemann commented Dec 4, 2024

@l-heemann l-heemann force-pushed the 5.x-wait-notifications branch 3 times, most recently from b329dd8 to 2a9c368 Compare December 4, 2024 11:47
@l-heemann
Copy link
Contributor Author

@renetapopova renetapopova self-requested a review December 5, 2024 11:39
modules/ROOT/pages/changelogs.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/changelogs.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @l-heemann. I added some editorial comments.

modules/ROOT/pages/changelogs.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/changelogs.adoc Outdated Show resolved Hide resolved
@renetapopova
Copy link
Collaborator

Hey @l-heemann, why are these notifications under GENERIC and not under TOPOLOGY, where we also have Server already enabled, etc.?

@l-heemann
Copy link
Contributor Author

Hey @l-heemann, why are these notifications under GENERIC and not under TOPOLOGY, where we also have Server already enabled, etc.?

You're right, it should be TOPOLOGY, I'll update

@l-heemann l-heemann force-pushed the 5.x-wait-notifications branch from 8ab73f1 to 3321f93 Compare December 11, 2024 08:16
@l-heemann
Copy link
Contributor Author

Hey @l-heemann, why are these notifications under GENERIC and not under TOPOLOGY, where we also have Server already enabled, etc.?

Fixed both here and in the neo4j PR https://github.com/neo-technology/neo4j/pull/28163 please review @renetapopova

@renetapopova renetapopova force-pushed the 5.x-wait-notifications branch from 3321f93 to 3262996 Compare December 11, 2024 10:53
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova self-requested a review December 11, 2024 11:14
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. I just updated the table GQLSTATUS groups of codes as defined by Neo4j.

@neo-technology-commit-status-publisher
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-status-codes-231.surge.sh

Updated pages:

@l-heemann
Copy link
Contributor Author

l-heemann commented Dec 11, 2024

Neo4j PR is merged, can this also be merged now @renetapopova ?

@renetapopova renetapopova merged commit b207b1e into neo4j:dev Dec 11, 2024
4 checks passed
@NataliaIvakina
Copy link
Collaborator

This PR is merged. But the question is -- should we use 'Cypher5' or 'Cypher 5'? With or without space before the version number. In the Cypher manual, Cypher names are with spaces.

@l-heemann
Copy link
Contributor Author

This PR is merged. But the question is -- should we use 'Cypher5' or 'Cypher 5'? With or without space before the version number. In the Cypher manual, Cypher names are with spaces.

With space is better imo, sorry about that

@renetapopova
Copy link
Collaborator

We can fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants