-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifications for WAIT commands #231
Conversation
b329dd8
to
2a9c368
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @l-heemann. I added some editorial comments.
a6c00de
to
9dd46c2
Compare
Hey @l-heemann, why are these notifications under GENERIC and not under TOPOLOGY, where we also have Server already enabled, etc.? |
You're right, it should be TOPOLOGY, I'll update |
8ab73f1
to
3321f93
Compare
Fixed both here and in the neo4j PR https://github.com/neo-technology/neo4j/pull/28163 please review @renetapopova |
3321f93
to
3262996
Compare
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. I just updated the table GQLSTATUS groups of codes as defined by Neo4j.
This PR includes documentation updates Updated pages: |
Neo4j PR is merged, can this also be merged now @renetapopova ? |
This PR is merged. But the question is -- should we use 'Cypher5' or 'Cypher 5'? With or without space before the version number. In the Cypher manual, Cypher names are with spaces. |
With space is better imo, sorry about that |
We can fix it later. |
Depends on https://github.com/neo-technology/neo4j/pull/28163