Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning that parsing status descriptions is not recommended #228

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Add a warning that parsing status descriptions is not recommended #228

merged 3 commits into from
Nov 29, 2024

Conversation

renetapopova
Copy link
Collaborator

No description provided.

@renetapopova renetapopova requested a review from Lojjs November 29, 2024 13:01
Lojjs
Lojjs requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just think we should write out the full "status description" so people are not confusing it with the old description for notifications

modules/ROOT/pages/errors/gql-errors.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
@renetapopova
Copy link
Collaborator Author

Nice, I just think we should write out the full "status description" so people are not confusing it with the old description for notifications

Yes, you're right.

@renetapopova renetapopova requested a review from Lojjs November 29, 2024 14:10
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 58fbb09 into neo4j:dev Nov 29, 2024
5 checks passed
@renetapopova renetapopova deleted the dev-messages-can-change branch November 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lojjs Lojjs Lojjs approved these changes

Assignees
No one assigned
Labels
5.26
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renetapopova @neo-technology-commit-status-publisher @Lojjs