Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify situation around the UNION reordering deprecation #224

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Clarify situation around the UNION reordering deprecation #224

merged 4 commits into from
Nov 27, 2024

Conversation

NataliaIvakina
Copy link
Collaborator

@NataliaIvakina NataliaIvakina commented Nov 25, 2024 •
edited by renetapopova
Loading

Supersedes #219

renetapopova
renetapopova reviewed Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NataliaIvakina. It looks fine. I am just wondering if we can turn this note into a footnote and add it to both the label in the table and the example heading.

modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/notifications/all-notifications.adoc Outdated Show resolved Hide resolved
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@neo-technology-commit-status-publisher
Copy link
Collaborator

This PR includes documentation updates
View the updated docs at https://neo4j-docs-status-codes-224.surge.sh

Updated pages:

@renetapopova renetapopova mentioned this pull request Nov 26, 2024
Closed
@NataliaIvakina
Copy link
Collaborator Author

NataliaIvakina commented Nov 26, 2024 •
edited
Loading

Thanks, @NataliaIvakina. It looks fine. I am just wondering if we can turn this note into a footnote and add it to both the label in the table and the example heading.

I don't know. I think a footnote is less visible than a note. Where do you suggest to place this footnote?

gem-neo4j
gem-neo4j approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@gem-neo4j gem-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me :) thanks

@NataliaIvakina NataliaIvakina merged commit 0076963 into neo4j:dev Nov 27, 2024
5 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-update-example branch November 27, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gem-neo4j gem-neo4j gem-neo4j approved these changes

@renetapopova renetapopova renetapopova approved these changes

Assignees

@gem-neo4j gem-neo4j

Labels
5.26
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NataliaIvakina @neo-technology-commit-status-publisher @renetapopova @gem-neo4j