WIP: Work with other float dtypes (float64, float16) #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a start at this, since it came up when working on another repo.
TODO:
Lowpass
to work with other dtypes (e.g. the current value of 1e-8 will go to 0 if converted to float16). In the specific case ofLowpass
, this epsilon probably doesn't need to be so small, since evennp.exp(-1 / 1e-3) == 0.0
.