Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Work with other float dtypes (float64, float16) #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

hunse
Copy link
Contributor

@hunse hunse commented Jul 26, 2021

Just a start at this, since it came up when working on another repo.

TODO:

  • Test that dtypes are properly conserved in layers and cells (i.e. output dtype matches layer dtype).
  • Run some tests with multiple dtypes.
  • Change epsilon (1e-8) used in e.g. Lowpass to work with other dtypes (e.g. the current value of 1e-8 will go to 0 if converted to float16). In the specific case of Lowpass, this epsilon probably doesn't need to be so small, since even np.exp(-1 / 1e-3) == 0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant