fix: set nullable true when default value is null #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heiglandreas
force-pushed
the
update-nullables-from-reflection
branch
from
4357ef7 to
9c775b0
Compare
heiglandreas
changed the title
heiglandreas
force-pushed
the
update-nullables-from-reflection
branch
from
9c775b0 to
3cb0e0c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2390 +/- ##
==========================================
+ Coverage 89.50% 89.53% +0.03%
==========================================
Files 78 78
Lines 2896 2915 +19
==========================================
+ Hits 2592 2610 +18
- Misses 304 305 +1 ☔ View full report in Codecov by Sentry. |
heiglandreas
force-pushed
the
update-nullables-from-reflection
branch
2 times, most recently
from
2ee2ccd to
7489b46
Compare
When reflection shows that the default parameter of a a property is null, then the `nullable` parameter is set to `true` for that property. Currently that needs to be set via the attribute but that is a bit redundant as the information is already available from reflection This change only does that for properties and for setter methods. Right now getter methods that allow a null value to be returned are not taken into account for setting the `nullable` property.
heiglandreas
force-pushed
the
update-nullables-from-reflection
branch
from
7489b46 to
318d00d
Compare
DjordyKoert
reviewed
Nov 15, 2024
|
Excuse me for the late merge, had it busy. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reflection shows that the default parameter of a a property is null, then the
nullableparameter is set totruefor that property.Currently that needs to be set via the attribute but that is a bit redundant as the information is already available from reflection
This change only does that for properties and for setter methods.
Right now getter methods that allow a null value to be returned are not taken into account for setting the
nullableproperty.This resets the state prior to v4.25.0 and is related to #2330
This is a refactor of #2377
What type of PR is this? (check all applicable)
Checklist
docs/)CHANGELOG.md)