refactor: reorganize reconsensus #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an idea for improving code structure in reconsensus module: - split away blocks requiring realignment early - separate logic for mutation-only reconsensus and full reconsensus Additionally: - make `find_majority*` functions into methods of `Block` - they look very much like fancy accessors
- Use iterator count instead of collecting to vector for performance - Only create vector when needed for error message formatting - Reduces heap allocations in common case paths
- Improves consistency with field name 'subs' - More concise while maintaining clarity - Follows existing naming patterns in codebase
mmolari
reviewed
Aug 1, 2025
| args: &PangraphBuildArgs, | ||
| ) -> Result<(), Report> { | ||
| // First apply mutations | ||
| apply_mutation_reconsensus(block, &majority_edits.subs)?; |
There was a problem hiding this comment.
this might be redundant, edits are already applied later...
There was a problem hiding this comment.
Where? Cannot figure it out
There was a problem hiding this comment.
It's a bit hidden, but if I'm not mistaken here all mutations get applied to the consensus, including substitutions, and then everything gets realigned to it anyways, so we won't need to deal with mutation separately.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #158
Updated version of #163 (on top of new changes in #158)
This is an idea for improving code structure in reconsensus module:
Additionally:
find_majority*functions into methods ofBlock- they look very much like fancy accessorsNOTE: This is simply an idea, with large portions of code generated by AI. Needs some verification.