feat: make error message in mmseqs run prettier #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows `color_eyre` conventions and uses different sections to make error message prettier. I think that chaining `.arg()` and then adding `-k` with `.args()` does not necessarily actually adds `-k`, but I don't know how to check it. So I opted for manually constructing all-in-one array of args, which I pass using a single `.args()` call. This also allow us to print the full command to the user and inspect it during debugging. Also refactored and simplified things a little. 
mmolari
approved these changes
Jan 23, 2025
ivan-aksamentov
added a commit
that referenced
this pull request
Jan 23, 2025
After #115 where I tested mmseqs errors, I forgot to flip back the `--threads` arg to the correct spelling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows
color_eyreconventions and uses different sections to make error message prettier.I think that chaining
.arg()and then adding-kwith.args()does not necessarily actually adds-k, but I don't know how to check it. So I opted for manually constructing all-in-one array of args, which I pass using a single.args()call. This also allow us to print the full command to the user and inspect it during debugging.Also refactored and simplified things a little.