feat: Add force_destroy options to prevent accidental data loss #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the solution for #8 by adding configuration options to prevent accidental deletion of storage buckets and database credentials when disabling the MLflow plugin.
Changes
force_destroy_storageandforce_destroy_db_credsconfiguration options to the MLflow plugin schemafalseto preserve resources by defaultprevent_destroyrules to storage resourcesConfiguration
Users can now control resource deletion with explicit flags:
Test plan
force_destroy_storage: falseforce_destroy_db_creds: falsetrueFixes #8
🤖 Generated with Claude Code