test: integration test for NIC PR #201 — configurable StorageClass & MetalLB#15
Closed
viniciusdc wants to merge 1 commit intomainfrom
Closed
test: integration test for NIC PR #201 — configurable StorageClass & MetalLB#15viniciusdc wants to merge 1 commit intomainfrom
viniciusdc wants to merge 1 commit intomainfrom
Conversation
Pins install-nic.sh to the feature/local-configurable-infra-settings branch of NIC (nebari-dev/nebari-infrastructure-core#201) to provide an end-to-end integration test environment for that PR review. PR #201 makes StorageClass, MetalLB address pool, and https_port configurable in the local provider config. This unlocks two changes: 1. deploy-platform.sh: set storage_class: local-path in the NIC config so NIC uses k3s's native StorageClass instead of 'standard'. 2. create-cluster.sh: remove the kubectl apply workaround that created a fake 'standard' StorageClass backed by rancher.io/local-path (the TODO block referencing #201 is now resolved). 3. deploy-platform.sh: explicitly declare metallb.address_pool in the NIC config to make the coupling between the Docker network subnet (create-cluster.sh) and the MetalLB pool visible and explicit. This branch is NOT intended to be merged until NIC PR #201 lands on main. At that point, NIC_BRANCH should be reverted to 'main'. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is a review/test vehicle for nebari-dev/nebari-infrastructure-core#201 — it is not intended to be merged until that NIC PR lands on
main.The CI run of this PR exercises the
platformprofile end-to-end against the NICfeature/local-configurable-infra-settingsbranch, giving us real integration coverage for #201 before it merges.What NIC PR #201 adds
Makes three fields configurable in the local provider config block:
storage_classstandardlocal-path(k3s native)metallb.address_pool192.168.1.100-192.168.1.110metallb.enabledtruehttps_port443Changes in this PR
scripts/install-nic.shNIC_BRANCHtofeature/local-configurable-infra-settingsfor PR testingscripts/deploy-platform.shstorage_class: local-pathto the NIC config — k3s shipslocal-path, notstandardmetallb.address_pool: 192.168.1.100-192.168.1.110explicitly to make the coupling between the Docker network subnet and the MetalLB pool visiblescripts/create-cluster.shstandardStorageClass workaround (thekubectl applyblock that created a fakestandardclass backed byrancher.io/local-path). This workaround had a TODO pointing directly at #201.After NIC PR #201 merges
NIC_BRANCHback tomainininstall-nic.sh