Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NumericUnderscores extensions from CLI/config #1618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

9999years
Copy link
Contributor

Closes #1434

Supercedes #1435, updated for latest master.

Copy link
Collaborator

@zliu41 zliu41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer this to @ndmitchell. I think the intention of passing extensions to HLint is for parsing, not for deciding if a hint should trigger, although it seems reasonable to do the latter.

Even if we decide to do that, this PR will need a few more updates:

  • I'm not seeing how you are passing the additional extensions from the Yaml config to the places that need them.
  • Since the additional extensions are from the HLint config and not tied to individual modules, it doesn't seem to make sense to associate them with ModuleEx.
  • Need to add some tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HLint seems to ignore -XNumericUnderscores
3 participants