Error formatting and error tests #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillchristian
commented
Oct 19, 2024
| @@ -149,6 +149,7 @@ impl Frame { | |||
| Frame::Error(s) => { | |||
| let mut bytes = Vec::with_capacity(1 + s.len() + CRLF.len()); | |||
| bytes.push(u8::from(DataType::SimpleError)); | |||
| bytes.extend_from_slice("ERR ".as_bytes()); | |||
There was a problem hiding this comment.
All errors have the prefix ERR
$ redis-cli
127.0.0.1:6379> SET incr_by_key_4 234293482390480948029348230948
OK
127.0.0.1:6379> INCRBY incr_by_key_4 10
(error) ERR value is not an integer or out of range
127.0.0.1:6379> foo
(error) ERR unknown command 'foo', with args beginning with:
127.0.0.1:6379> bar
(error) ERR unknown command 'bar', with args beginning with:
127.0.0.1:6379> set foo
(error) ERR wrong number of arguments for 'set' command
The create even removes the first work because it assumes the server is sending the error with that prefix.
Initially I did some string manipulation to get the tests to pass but then I realized I should just add the ERR prefix and now it works.
There was a problem hiding this comment.
This is great work! I was also thinking in doing some string manipulation. Glad you found this.
ndelvalle
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.