Cross build luajit to aarch64-linux from x86 host #160
Conversation
|
why the |
Thanks for reviewing. |
build/luajit.zig
Outdated
| @@ -96,12 +123,18 @@ pub fn configure(b: *Build, target: Build.ResolvedTarget, optimize: std.builtin. | |||
| buildvm.step.dependOn(&dynasm_run.step); | |||
| buildvm.step.dependOn(&genversion_run.step); | |||
|
|
|||
| const buildvm_c_flags = switch (target.result.cpu.arch) { | |||
| .aarch64, .aarch64_be => &[_][]const u8{ "-DLUAJIT_TARGET=LUAJIT_ARCH_arm64", "-DLJ_ARCH_HASFPU=1", "-DLJ_ABI_SOFTFP=0" }, | |||
There was a problem hiding this comment.
is this appropriate for every instance of an aarch64 target? also i think preferred zig style would be to give buildvm_c_flags type []const []const u8 and instead use &.{ // ... } instantiation here.
There was a problem hiding this comment.
Sorry I don't get what "every instance" mean here
Thanks for the zig style variable insturction, I'll update it.
There was a problem hiding this comment.
for example, are these flags appropriate for building when targeting macos-aarch64?
2. Add cross build for lua51 and luajit 3. Add editorconfig
2. Use zig-style variable for buildvm_c_flags
Ths PR includes
The aim is to build neovim with luajit support for raspberry pi aarch64 from x86 host