Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified the sanitizeForSerialization method to remove unnecessary re… #7950

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Dec 9, 2024

Closes #7933 (again)

Describe your changes:

A last minute change to remove array handling was done incorrectly and resulted in non unique subscriptions for objects with filters. Also, the replacer function for being used during JSON.stringify was unnecessarily recursing the object by calling itself, this is unnecessary because JSON.stringify doest this. ALSO, the test was bonkers wrong and not working, clearly as this issue passed while being broken.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

…cursion, update e2e test to CORRECTLY test the functionality
@jvigliotta jvigliotta added this to the Build 9 RC11 milestone Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.57%. Comparing base (d74e1b1) to head (a9f5b0f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7950      +/-   ##
==========================================
- Coverage   57.67%   57.57%   -0.10%     
==========================================
  Files         678      678              
  Lines       27428    27428              
  Branches     2691     2691              
==========================================
- Hits        15820    15793      -27     
- Misses      11270    11294      +24     
- Partials      338      341       +3     
Flag Coverage Δ
e2e-ci 62.85% <100.00%> (+0.04%) ⬆️
e2e-full 41.97% <87.50%> (ø)
unit 49.36% <87.50%> (-0.14%) ⬇️
Files with missing lines Coverage Δ
src/api/telemetry/TelemetryAPI.js 90.03% <100.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d74e1b1...a9f5b0f. Read the comment docs.

@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 9, 2024
@akhenry akhenry enabled auto-merge (squash) December 9, 2024 20:21
@akhenry akhenry added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Dec 9, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 9, 2024
@akhenry akhenry merged commit 5be103e into master Dec 9, 2024
62 checks passed
@akhenry akhenry deleted the subscription-key-fix branch December 9, 2024 20:34
akhenry pushed a commit that referenced this pull request Dec 9, 2024
#7950)

modified the sanitizeForSerialization method to remove unnecessary recursion, update e2e test to CORRECTLY test the functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TelemetryAPI] Subscriptions need to be unique based on request options
2 participants