-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In progress activities that are out of bounds are shown #7945
Conversation
…urrently visible list.
Needs tests: Will be done later. (#7946) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7945 +/- ##
==========================================
+ Coverage 56.71% 57.56% +0.85%
==========================================
Files 678 678
Lines 27427 27428 +1
Branches 2691 2691
==========================================
+ Hits 15556 15790 +234
+ Misses 11529 11297 -232
+ Partials 342 341 -1
... and 31 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If an activity is out of bounds, but in progress, display it in the currently visible list.
Closes: VIPERGC-700
Closes
Describe your changes:
If an activity is out of bounds, but in progress, display it in the currently visible list.
In progress status is checked by comparing the activity-states map for the given activity and comparing it's value with
in-progress
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist