Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In progress activities that are out of bounds are shown #7945

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Dec 6, 2024

Closes: VIPERGC-700

Closes

Describe your changes:

If an activity is out of bounds, but in progress, display it in the currently visible list.
In progress status is checked by comparing the activity-states map for the given activity and comparing it's value with in-progress

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@davetsay davetsay added this to the Target:4.1.0 milestone Dec 6, 2024
@shefalijoshi
Copy link
Contributor Author

shefalijoshi commented Dec 6, 2024

Needs tests: Will be done later. (#7946)

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.56%. Comparing base (5bb6a18) to head (b436e3a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7945      +/-   ##
==========================================
+ Coverage   56.71%   57.56%   +0.85%     
==========================================
  Files         678      678              
  Lines       27427    27428       +1     
  Branches     2691     2691              
==========================================
+ Hits        15556    15790     +234     
+ Misses      11529    11297     -232     
+ Partials      342      341       -1     
Flag Coverage Δ
e2e-ci 62.79% <ø> (+1.58%) ⬆️
e2e-full 41.95% <ø> (+18.30%) ⬆️
unit 49.32% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
src/plugins/timelist/TimelistComponent.vue 64.79% <100.00%> (+0.18%) ⬆️

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb6a18...b436e3a. Read the comment docs.

Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shefalijoshi shefalijoshi enabled auto-merge (squash) December 6, 2024 20:58
@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 6, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 6, 2024
@shefalijoshi shefalijoshi merged commit d74e1b1 into master Dec 6, 2024
23 checks passed
@shefalijoshi shefalijoshi deleted the fix-in-progress-oob-timelist-activities branch December 6, 2024 22:38
akhenry pushed a commit that referenced this pull request Dec 6, 2024
If an activity is out of bounds, but in progress, display it in the currently visible list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants