-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notebook] Browse Bar holding onto stale model, reverts changes #7944
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7944 +/- ##
==========================================
- Coverage 57.68% 57.57% -0.12%
==========================================
Files 678 678
Lines 27427 27427
Branches 2691 2691
==========================================
- Hits 15822 15790 -32
- Misses 11267 11296 +29
- Partials 338 341 +3
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* moving rename methods to appActions * importing back into original test * reverting * add the ability to change the name in the browse bar * add test to verify entries are not being lost * addding aria labels for tests * when an object is changed, store the whole new object, not just the name * typo!
Closes #7943 7943
Describe your changes:
In Browse.js instead of just watching the name of the domain object to update the page title, we watch the whole object and update the whole object, while also updating the page title if necessary.
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist