Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notebook] Browse Bar holding onto stale model, reverts changes #7944

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Dec 6, 2024

Closes #7943 7943

Describe your changes:

In Browse.js instead of just watching the name of the domain object to update the page title, we watch the whole object and update the whole object, while also updating the page title if necessary.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@jvigliotta jvigliotta added this to the Build 9 RC11 milestone Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.57%. Comparing base (14b947c) to head (de4e846).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7944      +/-   ##
==========================================
- Coverage   57.68%   57.57%   -0.12%     
==========================================
  Files         678      678              
  Lines       27427    27427              
  Branches     2691     2691              
==========================================
- Hits        15822    15790      -32     
- Misses      11267    11296      +29     
- Partials      338      341       +3     
Flag Coverage Δ
e2e-ci 62.81% <100.00%> (ø)
e2e-full 41.92% <66.66%> (-0.08%) ⬇️
unit 49.35% <66.66%> (-0.15%) ⬇️
Files with missing lines Coverage Δ
src/ui/layout/BrowseBar.vue 40.33% <ø> (-3.37%) ⬇️
src/ui/router/Browse.js 93.33% <100.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b947c...de4e846. Read the comment docs.

src/ui/router/Browse.js Outdated Show resolved Hide resolved
@jvigliotta jvigliotta requested a review from akhenry December 6, 2024 21:00
@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 6, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Dec 6, 2024
@akhenry akhenry merged commit 5bb6a18 into master Dec 6, 2024
38 checks passed
@akhenry akhenry deleted the vipergc-702 branch December 6, 2024 22:13
akhenry pushed a commit that referenced this pull request Dec 6, 2024
* moving rename methods to appActions

* importing back into original test

* reverting

* add the ability to change the name in the browse bar

* add test to verify entries are not being lost

* addding aria labels for tests

* when an object is changed, store the whole new object, not just the name

* typo!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notebook] Changing notebook name in browse bar can cause any changes in notebook to disappear
2 participants