-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(visual): add unclipped activity names visual tests + a11y fixes #7454
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7454 +/- ##
==========================================
- Coverage 55.59% 55.57% -0.02%
==========================================
Files 668 668
Lines 26800 26800
Branches 2606 2606
==========================================
- Hits 14899 14894 -5
- Misses 11185 11190 +5
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@ozyx Do you have an issue associated with the bug that this fixes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a lint fix
@@ -29,13 +29,15 @@ | |||
v-if="isCollapsable" | |||
class="l-pane__collapse-button c-icon-button" | |||
:name="collapseTitle" | |||
:aria-label="collapseTitle" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that we had to do this. I I updated every title that was missing an Aria label
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was also surprised
Closes #7455
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist