Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(visual): add unclipped activity names visual tests + a11y fixes #7454

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Feb 2, 2024

Closes #7455

Describe your changes:

  • Adds 2 visual tests covering Gantt Charts w/ unclipped activity names in draft and non-draft status modes.
  • Small a11y fix for the inspector pane expand/collapse button
  • Add additional dictionaries to cspell that we weren't using

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Is this a breaking change to be called out in the release notes?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Feb 2, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Feb 2, 2024
@ozyx ozyx requested a review from unlikelyzero February 2, 2024 05:45
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cbaa7b) 55.59% compared to head (4a2a046) 55.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7454      +/-   ##
==========================================
- Coverage   55.59%   55.57%   -0.02%     
==========================================
  Files         668      668              
  Lines       26800    26800              
  Branches     2606     2606              
==========================================
- Hits        14899    14894       -5     
- Misses      11185    11190       +5     
  Partials      716      716              
Flag Coverage Δ *Carryforward flag
e2e-full 49.02% <ø> (ø) Carriedforward from 3cbaa7b
e2e-stable 59.06% <ø> (-0.04%) ⬇️
unit 48.54% <100.00%> (-0.05%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/ui/layout/PaneContainer.vue 48.80% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cbaa7b...4a2a046. Read the comment docs.

@unlikelyzero
Copy link
Contributor

@ozyx Do you have an issue associated with the bug that this fixes?

Copy link
Contributor

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a lint fix

@@ -29,13 +29,15 @@
v-if="isCollapsable"
class="l-pane__collapse-button c-icon-button"
:name="collapseTitle"
:aria-label="collapseTitle"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that we had to do this. I I updated every title that was missing an Aria label

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was also surprised

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 2, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 2, 2024
@unlikelyzero unlikelyzero enabled auto-merge (squash) February 2, 2024 19:10
@unlikelyzero unlikelyzero merged commit ee5081f into master Feb 2, 2024
24 checks passed
@unlikelyzero unlikelyzero deleted the more-visual-tests-for-gantt branch February 2, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add visual tests for Gantt Chart "unclipped" activity names
2 participants