MMT-4138: Check for assurance level 4 and role for non NASA MMT access #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## MMT-3759 #1429 +/- ##
===========================================
Coverage ? 98.19%
===========================================
Files ? 433
Lines ? 7082
Branches ? 1519
===========================================
Hits ? 6954
Misses ? 127
Partials ? 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
htranho
requested review from
cgokey,
eudoroolivares2016,
mandyparson and
william-valencia
cgokey
reviewed
Dec 4, 2025
cgokey
reviewed
Dec 4, 2025
| throw new Error(`HTTP error! status: ${response.status}`) | ||
| } | ||
|
|
||
| const data = await response.json() |
Collaborator
There was a problem hiding this comment.
data.items isn't guaranteed to exist, can we default items to [] ?
cgokey
reviewed
Dec 4, 2025
| const ErrorUnauthorizedAccess = () => { | ||
| const location = useLocation() | ||
| const queryParams = new URLSearchParams(location.search) | ||
| const errorType = queryParams.get('errorType') || 'default' |
cgokey
reviewed
Dec 4, 2025
| <AuthContext.Provider value={context}> | ||
| <MemoryRouter initialEntries={[`/unauthorized?errorType=${errorType}`]}> | ||
| <Routes> | ||
| <Route path="/unauthorized" element={<ErrorUnauthorizedAccess />} /> |
Collaborator
There was a problem hiding this comment.
We should match the route name to actual name in the implementation, unauthorizedAccess
cgokey
approved these changes
Dec 4, 2025
mandyparson
reviewed
Dec 4, 2025
| } | ||
| } | ||
|
|
||
| if (assuranceLevel === 4) { |
| const response = await edlCallback(mockEvent) | ||
|
|
||
| expect(response.statusCode).toBe(303) | ||
| expect(response.headers.Location).toBe('https://mmt.example.com/unauthorizedAccess?errorType=nonNasaMMT') |
Contributor
There was a problem hiding this comment.
Below this,
expect(checkNonNasaMMTAccess).toHaveBeenCalledTimes(1)
Anywhere in this file where you have a .toHAveBeenCalledWith(), there should be an accompanying .toHaveBeenCalledTimes()
|
|
||
| await expect(checkNonNasaMMTAccess('testUser', 'testToken')).rejects.toThrow('Network error') | ||
| expect(consoleSpy).toHaveBeenCalledWith('Error checking Non-NASA MMT access:', expect.any(Error)) | ||
| consoleSpy.mockRestore() |
static/src/js/components/ErrorUnauthorizedAccess/ErrorUnauthorizedAccess.jsx
Outdated
Show resolved
Hide resolved
mandyparson
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Check for assurance level 4 and role for non NASA MMT access
What is the Solution?
Check for assurance level 4 and role for non NASA MMT access
What areas of the application does this impact?
Non NASA MMT (Draft MMT)
Testing
Assurance level has to be '4' and ACL has 'name' containing NON_NASA_DRAFT_USER. Error pages for level less than 4 or level 4 but no role assigned.
Attachments
Checklist