use gh runners in ci - #5019
Merged
Merged
Conversation
Fraccaman
force-pushed
the
use-gh-runners-ci
branch
from
August 5, 2026 09:37
3bf82db to
445ed56
Compare
Fraccaman
force-pushed
the
use-gh-runners-ci
branch
7 times, most recently
from
August 5, 2026 14:00
d064f09 to
aa8e53a
Compare
There was a problem hiding this comment.
🔵 Human review recommended
It changes critical CI runner selection/caching infrastructure and also removes MSRV verification from PR checks without an evident replacement.
Pull request overview
This PR updates the project’s GitHub Actions configuration to use new runner labels / caching infrastructure and adjusts an IBC MASP-related E2E test timing to avoid shielding before conversions are published.
Changes:
- Switch multiple CI and docker workflows to new
namada-runners-*runners and update cache/role environment variables, including centralizing defaultRUSTFLAGS. - Extend the
ibc_token_inflationE2E test wait period to include an additional MASP epoch, and update the expected runtime budget ine2e.json. - Remove the MSRV verification job from the PR workflow and apply a minor formatting-only change in
release.yml.
File summaries
| File | Description |
|---|---|
| crates/tests/src/e2e/ibc_tests.rs | Wait longer before shielding to ensure MASP conversions exist, preventing permanent “undated note” behavior from invalidating inflation checks. |
| .github/workflows/scripts/e2e.json | Increase the scheduled budget for ibc_token_inflation to reflect the longer wait. |
| .github/workflows/release.yml | Formatting-only adjustment (no functional change). |
| .github/workflows/pr.yml | Removes the MSRV (cargo-msrv) job from PR checks. |
| .github/workflows/docker.yml | Moves the docker workflow to the new runner label. |
| .github/workflows/ci.yml | Migrates CI jobs to new runner labels and updates cache/role/env wiring; centralizes default RUSTFLAGS with targeted overrides. |
Review details
Suppressed comments (1)
.github/workflows/pr.yml:89
- The PR workflow no longer runs the MSRV verification job (cargo-msrv) and there doesn’t appear to be an equivalent check in other workflows; this reduces CI coverage for the project’s minimum supported Rust version and may allow MSRV regressions to merge unnoticed. If the intent is to disable it, consider adding an explicit rationale in the PR description and/or moving MSRV verification to another workflow (e.g., ci.yml or a scheduled workflow) rather than removing it entirely.
uses: actions-ecosystem/action-add-labels@v1
if: steps.semver.outcome == 'failure'
with:
labels: "breaking:api"
- Files reviewed: 5/6 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
sug0
approved these changes
Aug 5, 2026
sug0
left a comment
sug0
left a comment
Collaborator
There was a problem hiding this comment.
I'd also get rid of the changelog stuff in ci
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Contributor
Merge Queue Status
This pull request spent 38 minutes 48 seconds in the queue, including 37 minutes 39 seconds running CI. Waiting for any of
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks
Failing checks:
HintYou may have to fix your CI before adding the pull request to the queue again. Requeued — the merge queue status continues in this comment ↓. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Hey @Fraccaman, your pull request has been dequeued due to the following reason: CHECKS_FAILED. |
Fraccaman
force-pushed
the
use-gh-runners-ci
branch
from
August 6, 2026 08:21
aa8e53a to
f7736f3
Compare
Collaborator
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 59 minutes 28 seconds in the queue, including 57 minutes 33 seconds running CI. Required conditions to merge
|
3 tasks
mergify Bot
added a commit
that referenced
this pull request
Aug 6, 2026
use gh runners in ci (backport #5019)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo