-
Notifications
You must be signed in to change notification settings - Fork 1k
Handle IBC deposits/withdraws to/from payment addresses #4939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sug0
wants to merge
34
commits into
main
Choose a base branch
from
tiago/znam-ibc-shielding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 CI InsightsHere's what we observed from your CI run for 6c2f1ab. 🟢 All jobs passed!But CI Insights is watching 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking:consensus
Consensus breaking change that requires a hard-fork
breaking-change
do-not-merge
Do not merge for now
IBC
MASP
UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4830
Closes #4168
TODO: fix masp indexer and shielded sync code
TODO: update dated/undated masp balances in storage
TODO: alter ibc transfer client code, to add a payment addr as a refund target
TODO: update masp vp
TODO: write a few test cases to check shielded refunding + memoless shielded deposits
TODO: set
indexed_txvalue inin_memstate when evaluating wasm txsAllow IBC deposits into payment addresses (without generating MASP transactions), and IBC withdraws from payment addresses (to automatically get refunded, if an IBC unshielding transfer fails on the counter-party).
These changes should substantially improve the UX of MASP over IBC.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo