feat: port Namadillo to @namada/sdk-multicore v0.20.5 #2279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurevans
changed the title
jurevans
requested review from
euharrison,
mateuszjasiuk and
neocybereth
and removed request for
euharrison and
mateuszjasiuk
jurevans
commented
Aug 15, 2025
jurevans
force-pushed
the
feat/namadillo-sdk-0.20.2
branch
from
7571f85 to
b43d7b6
Compare
jurevans
changed the title
jurevans
changed the title
mateuszjasiuk
force-pushed
the
feat/namadillo-sdk-0.20.2
branch
3 times, most recently
from
f8b9602 to
1b8335c
Compare
mateuszjasiuk
force-pushed
the
feat/namadillo-sdk-0.20.2
branch
from
1b8335c to
8418a01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR begins the process of porting Namadillo over to
@namada/sdk-multicore-v0.20.2.@namada/sdk-multicore@namada/typesto@namada/sdk-multicorewhere necessaryMaspTxWorkerwasmbuild scripts Namadillo (no longer required)ShieldedSyncWorker, fixSdkEventsexport (from new multicore SDK)initimport innamadilo/src/index.tsx- this will require SDKv0.20.5that provides this export. Currently, Namadillo cannot directly access and await the wasm init promise (not without initializing the Sdk struct), so this has been added for all SDK packages@namada/sdk-node- Now passing in CI)TESTING
It is crucial that everything is tested end-to-end. The SDK APIs have not changed (outside of
initSdk), but there may be some edge-cases we haven't considered or something missed!TODO
@namada/sdkv0.20.2is published! (separate PR)packages/cryptopackages/sharedpackages/sdkpackages/types(partial - we may need to keep a few types, like anything shared by Namadillo & Keychain, but not in the SDK, but note that all Tx schema types and props are in the new SDK and should be included from there for all future releases!)