Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 60.82% 54.51% -6.31%
==========================================
Files 11 13 +2
Lines 929 1266 +337
==========================================
+ Hits 565 690 +125
- Misses 329 504 +175
- Partials 35 72 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request adds an export feature to persist load test results for downstream processing. The feature allows users to export attack results to CSV and JSON formats using the new --export-to flag.
Changes:
- Added
--export-toCLI flag to export results to a specified directory - Implemented CSV export for individual request data points (
results.csv) - Implemented JSON export for aggregated summary statistics (
summary-<id>.json)
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| export/export.go | Core export logic with atomic file writes, CSV/JSON serialization, and proper error handling |
| export/export_test.go | Comprehensive unit tests covering basic functionality, edge cases, and atomic writes |
| export_golden_test.go | Golden file tests validating CSV and JSON schema correctness |
| export_pending_test.go | Integration tests for CLI export functionality |
| attacker/attacker.go | Integration of export functionality into the attack loop with UUID generation |
| attacker/summary.go | Conversion of metrics to export summary format |
| attacker/fake_attacker.go | Updated FakeAttacker to return error from Attack method |
| attacker/attacker_test.go | Updated tests for new Attack signature |
| gui/keybinds.go | Modified attack function to handle and propagate export errors |
| gui/gui.go | Export error handling in GUI lifecycle |
| gui/drawer.go | Thread-safe export error tracking |
| main.go | CLI integration with directory validation and exporter initialization |
| main_test.go | Updated CLI tests to include exportTo field |
| docs/export.md | User-facing documentation explaining export feature usage |
| docs/rfc/001-export.md | Design document with requirements and specifications |
| README.md | Updated with export feature description |
| testdata/export/* | Golden test data files for various scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 7f0072c.
Close #96
What changed
Add an export feature that persists load test results for downstream processing:
results.csvin a stable schema.summary-<id>.json.How to test