-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for @media
rule
#553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think this is a good implementation of media
which I believe it was requested before (and is very common) but I cannot find a specific issue to link. Of course it involves too many new parts and the majority of them should be inside Batik CSS and not in AntiSamy but it is the only way it can be done "fast". In fact, my recommendation is to suggest to implement it there, probably most of the code could be reused.
In my opinion, considering the comments of others it should be a non default feature, even though it is pretty restricted to specific values and simple regular expressions. Just to discourage people on using HTML filters for CSS as a miracle solution against XSS.
@spassarop May you have another look at my changes please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK now.
Thank you! |
Possible implementation for #552 .
Please feel free to review.