Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @media rule #553

Merged
merged 9 commits into from
Feb 18, 2025
Merged

Support for @media rule #553

merged 9 commits into from
Feb 18, 2025

Conversation

jonah1und1
Copy link
Contributor

Possible implementation for #552 .
Please feel free to review.

Copy link
Collaborator

@spassarop spassarop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think this is a good implementation of media which I believe it was requested before (and is very common) but I cannot find a specific issue to link. Of course it involves too many new parts and the majority of them should be inside Batik CSS and not in AntiSamy but it is the only way it can be done "fast". In fact, my recommendation is to suggest to implement it there, probably most of the code could be reused.

In my opinion, considering the comments of others it should be a non default feature, even though it is pretty restricted to specific values and simple regular expressions. Just to discourage people on using HTML filters for CSS as a miracle solution against XSS.

@jonah1und1 jonah1und1 requested a review from spassarop February 10, 2025 16:59
@jonah1und1
Copy link
Contributor Author

@spassarop May you have another look at my changes please?

Copy link
Collaborator

@spassarop spassarop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK now.

@jonah1und1
Copy link
Contributor Author

It's OK now.

Thank you!

@davewichers davewichers merged commit 833e1f2 into nahsra:main Feb 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants